Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sometimes include deletion times in domain-list exports #2602

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Sometimes include deletion times in domain-list exports #2602

wants to merge 1 commit into from

Conversation

gbrodman
Copy link
Collaborator

@gbrodman gbrodman commented Oct 28, 2024 •
edited by jianglai
Loading

We only include the deletion time if the domain is in the 5-day PENDING_DELETE period after the 30 day REDEMPTION period. For all other domains, we just have an empty string as that field.

This is behind a feature flag so that we can control when it is enabled

This change is Reviewable

@gbrodman
Sometimes include deletion times in domain-list exports
ea62366 
We only include the deletion time if the domain is in the 5-day
PENDING_DELETE period after the 30 day REDEMPTION period. For all other
domains, we just have an empty string as that field.

This is behind a feature flag so that we can control when it is enabled
@gbrodman
Copy link
Collaborator Author

thoughts on this approach? the SQL is a bit messier but we don't have to lead everything and we can just put it behind a feature flag until we're ready to enable it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CydeWeys CydeWeys Awaiting requested review from CydeWeys

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gbrodman